Skip to content

Conversation

@narbek-abd
Copy link

@narbek-abd narbek-abd commented Oct 30, 2024

Context

solves #2019

Changes & Results

Just added cc and mlo hanging protocols
image

Testing

Just open some mammo studies with &hangingprotocolId=mgCC or mgMLO

Notes

  1. In our case i actually added "any" attribute just in case:
seriesMatchingRules: [
  { weight: 2, attribute: "isLCC", constraint: { equals: { value: true } } },
  { weight: 1, attribute: "any", constraint: { equals: { value: true } } },
];

customAttributeRetrievalCallbacks = {
  ...
  any: {
    name: "any",
    callback: (displaySet) => true,
  },
  ...
};
  1. In Deploy Preview below there is two mammo studies, but they don't have R-MLO instance it seems

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Ubuntu ubuntu 22.04
  • Node version: v21.7.3
  • Browser: Chrome, Firefox

@netlify
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit d8e31fd
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6721c4bd311852000803fd03
😎 Deploy Preview https://deploy-preview-4445--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit d8e31fd
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6721c4bd07b5db0008fd3f8d
😎 Deploy Preview https://deploy-preview-4445--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi requested a review from wayfarer3130 October 30, 2024 15:12
@sedghi
Copy link
Member

sedghi commented Oct 30, 2024

Thanks a lot!

export const mgCC = {
id: 'mgCC',
name: 'mammo-cc',
imageLoadStrategy: 'interleaveTopToBottom',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the image load strategy out now - it is better handled with the progressive loading.

name: 'mammo-cc',
imageLoadStrategy: 'interleaveTopToBottom',
protocolMatchingRules: [
{ attribute: 'ModalitiesInStudy', constraint: { contains: ['MG', 'DX'] } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this probably needs a better rule so it doesn't trigger too often. We really need to add a way to have a constraint X and constraint Y or X2 and Y2. DX is probably too aggressive by itself

numberOfPriorsReferenced: -1,
};

export const mgMLO = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you aren't using the view code matcher? See mammoDisplaySetSElectors
The code looks like:
const LCCSeriesMatchingRules = [
{
weight: 10,
attribute: 'ViewCode',
constraint: {
contains: 'SCT:399162004',
},
},
{
weight: 5,
attribute: 'PatientOrientation',
constraint: {
contains: 'L',
},
},
{
weight: 20,
attribute: 'SeriesDescription',
constraint: {
contains: 'L CC',
},
},
];

@wayfarer3130
Copy link
Contributor

Could you start with hpMammo.ts and extend those hanging protocols?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants