fix: Allow test:e2e:serve to run with rsbuild #4749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/rsbuild-test-e2e
|
| Run status |
|
| Run duration | 02m 02s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
wayfarer3130
commented
Jan 30, 2025
package.json
Outdated
| "test:e2e:headed": "npx playwright test --headed", | ||
| "test:e2e:dist": "lerna run test:e2e:dist --stream", | ||
| "test:e2e:serve": "yarn test:data && lerna run test:e2e:serve --stream", | ||
| "test:e2e:fast": "lerna run test:e2e:fast --stream", |
Contributor
Author
There was a problem hiding this comment.
Add a fast version of the bun dev build
wayfarer3130
commented
Jan 30, 2025
| "test:e2e:dist": "lerna run test:e2e:dist --stream", | ||
| "test:e2e:serve": "yarn test:data && lerna run test:e2e:serve --stream", | ||
| "test:e2e:fast": "lerna run test:e2e:fast --stream", | ||
| "test:data:serve": "yarn test:data && cd testdata && dicomwebserver -c ./static-dicomweb.json5 -p 3030", |
Contributor
Author
There was a problem hiding this comment.
And checkout/run the dicomwebserver locally instead of incorporating that data into the rsbuild
wayfarer3130
changed the title
Member
|
as discussed we need to add dicomwebserve in dev dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
rsbuild does not provide a static file server configuration like that provided for webpack, so it becomes necessary to run a separate instance of a server on some port, and then forward the data, OR we could host the data somewhere in the cloud.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment