Skip to content

Comments

fix: measurementsAPI issue caused by production build#842

Merged
dannyrb merged 53 commits intoOHIF:masterfrom
dannyrb:fix/transpile-to-correct-browser-target
Sep 4, 2019
Merged

fix: measurementsAPI issue caused by production build#842
dannyrb merged 53 commits intoOHIF:masterfrom
dannyrb:fix/transpile-to-correct-browser-target

Conversation

@dannyrb
Copy link
Member

@dannyrb dannyrb commented Sep 3, 2019

Closes: 834

dannyrb added 30 commits August 26, 2019 15:11
# Conflicts:
#	.circleci/build-and-publish-docs.sh
#	.circleci/config.yml
# Conflicts:
#	.webpack/webpack.common.js
#	platform/viewer/package.json
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #842 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #842      +/-   ##
=========================================
- Coverage    9.97%   9.93%   -0.04%     
=========================================
  Files         234     234              
  Lines        5746    5748       +2     
  Branches     1075    1076       +1     
=========================================
- Hits          573     571       -2     
- Misses       4199    4202       +3     
- Partials      974     975       +1
Flag Coverage Δ
#core 13.67% <100%> (-0.05%) ⬇️
#viewer 0.54% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
platform/viewer/src/App.js 0% <ø> (ø) ⬆️
platform/viewer/src/index.js 0% <ø> (ø) ⬆️
...rm/core/src/measurements/classes/MeasurementApi.js 0.23% <ø> (-0.24%) ⬇️
platform/core/src/measurements/index.js 100% <ø> (ø) ⬆️
platform/viewer/src/store/index.js 0% <0%> (ø) ⬆️
platform/core/src/measurements/configuration.js 100% <100%> (ø) ⬆️
...form/core/src/measurements/classes/TimepointApi.js 0.87% <100%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e7232...6044f95. Read the comment docs.

@dannyrb dannyrb merged commit 49d3439 into OHIF:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant