Skip to content

This fixes #2, it adds PMIX and MPI libs to the MOC library.#4

Merged
gvallee merged 2 commits intomasterfrom
gv_libsfix
Dec 21, 2017
Merged

This fixes #2, it adds PMIX and MPI libs to the MOC library.#4
gvallee merged 2 commits intomasterfrom
gv_libsfix

Conversation

@gvallee
Copy link
Copy Markdown
Contributor

@gvallee gvallee commented Dec 21, 2017

No description provided.

@gvallee gvallee requested a review from naughtont3 December 21, 2017 16:48
@naughtont3
Copy link
Copy Markdown

Cool! Q: Should that be on LIBS instead of CPPFLAGS since it is adding linkage library?

@naughtont3
Copy link
Copy Markdown

OK, yes. This is good and fixes the test case I was using to reproduce error.

For ticket trails, here's the test I used to confirm things worked. (Enable ifdef in test/simple_test.c to exercise use of libmoc.so).

beaker:$ git br
* gv_libsfix
  master
beaker:$ git diff
diff --git a/test/simple_test.c b/test/simple_test.c
index a49fd7c..598b77f 100644
--- a/test/simple_test.c
+++ b/test/simple_test.c
@@ -7,7 +7,7 @@ main (int argc, char **argv)
 {
     int rc;
 
-#if 0
+#if 1
     rc = MOC_Init (NULL);
     if (rc != MOC_SUCCESS)
     {
beaker:$ ./autogen.sh && \
    ./configure  \
     --prefix=/home/tjn/projects/ompi-ecp/install \
    --with-mpi=/home/tjn/projects/ompi-ecp/install \
    --with-pmix=/home/tjn/projects/ompi-ecp/install \
&& make

Copy link
Copy Markdown

@naughtont3 naughtont3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants