pod install fails when using pnpm

[joprice]

When trying to use this project with pnpm, an error like the one below is raised when running pod install. It seems that the relative path used to find the project's root directory will not work with package managers that use symlinks with a global store. Perhaps an env var could be used similar to what's done here https://github.com/pnpm/pnpm/blob/main/workspace/find-workspace-dir/src/index.ts, or simply rely on the current working directory (although this would then assume that you're running the command in the parent directory).

Couldn't install Pods. Updating the Pods project and trying again...
Command `pod install` failed.
└─ Cause: Invalid `Podfile` file:
[!] Invalid `op-sqlite.podspec` file: No such file or directory @ rb_sysopen - <redacted_path>/../../../package.json

[ospfranco]

Does this happen with other packages? I don't think metro supports symlinks anyways. In any case, feel free to submit a PR, no time to investigate this myself

[joprice]

It looks like it was added a while back https://reactnative.dev/blog/2023/06/21/0.72-metro-package-exports-symlinks. But, without configuring that, I had been using pnpm with a react native project for a few weeks until installing this project, so it seems like the unstable flag might not even be needed anymore.

I was wondering how other projects do this, but so far only thought of codegen. Turns out it uses the app_path parameter https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L67 to find the package.json config. That pattern requires modifying podfile to pass the arg, so inconvenient. I'm going to poke around at other projects to see if anyone's come up with a convenient patter that works across bundlers. Otherwise, I'll try using an optional env var and falling back to the relative path.

[ospfranco]

Oh, I just got it, you mean reading the package.json from the podspec! Ah yeah, op-sqlite is quite unique in that regard. Let me know if you find anything.

[rodebert]

I am also running into this problem.

@joprice How did you get around it with using an env var? Or are there any other updates how to cope with this? Thanks in advance.

[joprice]

@rodebert Unfortunately, I ended up switching to npm for now for this one package until I can figure it out. Breaks the whole monorepo pattern, but all my shared code is written in FSharp via Fable, so I don't actually make use of pnpm workspaces otherwise except for keeping dependencies aligned, so for now it's workable.

[ospfranco]

You can use yarn or bun for workspaces no? But I guess moving all your monorepo just because this is not an option. Maybe recursively traverse up the dirs until a node_modules is found? I don't know how pnpm works.

[ospfranco]

We could make this work with an ENV variable you add to your podfile:

package_json_path = ENV['PACKAGE_JSON_PATH'] || File.join(__dir__, "..", "..", "..", "package.json")

It's not super smooth but with documentation and a warning if the package.json I guess it's enough for people that use monorepos. I guess we could make something similar for Androd.

[ospfranco]

Fix was faulty, re-opening this