Oscar/expand test suite #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospfranco
commented
Jan 23, 2025
| }); | ||
|
|
||
| function_map["close"] = HOSTFN("close") { | ||
| invalidated = true; |
Contributor
Author
There was a problem hiding this comment.
This is not necessarily a problem, but I discovered during hot reloads if the DB was already closed it would try to be invalidated again and sqlite does not like it.
subtleGradient
pushed a commit
to effect-native/op-sqlite
that referenced
this pull request
Sep 12, 2025
…d-test-suite Oscar/expand test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to expand the test suite a bit, more use cases pop up where not all code paths are covered, like #227
I've also found a concurrency bug when hot reloading, which should be fixed by marking the HostObjects as invalid as early as possible (at least from my testing)
I want to add more tests, but not sure what to cover at this point.