Abstract promise code and make simple result creation faster #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # example/ios/OPSQLiteExample/AppDelegate.mm # example/ios/Podfile.lock # example/package.json # example/src/App.tsx # package.json # src/index.ts # yarn.lock Working promisify Working thread pool Working off-thread work Simplify data Run on Android Faster row creation Single struct that captures all state to correctly invalidate a module clean up Global call invoker ref Comments Migrate other functions
ospfranco
changed the title
Comment on lines
+113
to
+115
| "dependencies": { | ||
| "react-native-safe-area-context": "^5.6.2" | ||
| } |
There was a problem hiding this comment.
@ospfranco Is this a mistake? I guess this should be only in the example no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the speed to execute (and executAsync) JS object creation by close to 50% by using clever caching of names and removing one loop in JS
The code that handles JS promises has also been abstracted away and it's now miles easier to work with than before. It's a worthy addition because it opens the doors for more async code in the future.