Fix handling of versions with suffix#16
Merged
bertrand-lorentz merged 2 commits intodevelopfrom Jun 5, 2023
Merged
Conversation
Some failing tests are commented out, this will be fixed in the next commit.
Use the Semver4j library to parse and manipulate the version. This allows to properly handle versions with a suffix like "1.2.3-rc.1" and "2.0.0-alpha.1" This also fixes equals() and compareTo() for versions with a suffix. Enable the unit tests that were failing before this fix.
rouschr
approved these changes
Jun 2, 2023
rousso
approved these changes
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not change the API, but corrects the behavior when the version has a suffix.