Feature: Add API for XPath parsing and processing (TEDEFO-2401)#23
Merged
bertrand-lorentz merged 5 commits intodevelopfrom Oct 20, 2023
Merged
Feature: Add API for XPath parsing and processing (TEDEFO-2401)#23bertrand-lorentz merged 5 commits intodevelopfrom
bertrand-lorentz merged 5 commits intodevelopfrom
Conversation
The ANTLR4 grammar is the same that was used in the EFX toolkit. Java code is generated from this grammar at build time.
Using a newer version causes errors
This consolidates the XPath parsing and manipulation done in various parts of the EFX toolkit into a single XPathProcessor class. Most of the code is copied over from the EFX toolkit. Unit tests are also copied from the corresponding tests in EFX tookit, with some new ones added.
Also indicate how to generate the report in the main README.
rouschr
requested changes
Oct 13, 2023
Contributor
rouschr
left a comment
rouschr
left a comment
There was a problem hiding this comment.
Apart from JavaDocs and formatting, I think as there are unit tests this should be at good start.
rouschr
approved these changes
Oct 16, 2023
rousso
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates the various XPath processing capabilities from the EFX toolkit into the eForms core library. See commit messages for more details.
This just adds APIs, so existing usage is not impacted. The removal of the corresponding features from the EFX toolkit is prepared and will be in a PR there once this is OK.
I'd welcome suggestions on the names of the new classes in the added API (XPathProcessor and XPathInfo).