TEDEFO-4940 Refactor and clean up the EFX expression preprocessor#148
Merged
bertrand-lorentz merged 2 commits intodevelopfrom Mar 2, 2026
Merged
Conversation
Contributor
bertrand-lorentz
left a comment
bertrand-lorentz
left a comment
There was a problem hiding this comment.
I can't really review those changes, but the unit test coverage seems OK.
See my comment for unit tests that do not explicitly assert anything.
src/test/java/eu/europa/ted/efx/sdk2/PreprocessorTypeResolutionTest.java
Outdated
Show resolved
Hide resolved
bertrand-lorentz
approved these changes
Mar 2, 2026
bertrand-lorentz
deleted the
TEDEFO-4940-refactor-efx-epression-preprocessor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.