Conversation
Member
|
Is this just code movement (with no functional changes)? |
Collaborator
Author
|
Yes that's right. |
Collaborator
Author
|
I suppose there are functional changes in that I have abolished the inheritance from |
dham
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
base.py,sequential.py,petsc_base.pyandpyparloop.pyand instead puts the classes into files such asdat.py,set.pyandparloop.py.As things stand I have created a
pyop2.typessubpackage and thrown most of the material in there. I would be interested in other people giving their opinions on how best to structure things.This PR is a prerequisite to #624 and should make reviewing that much more pleasant!
Linked PRs: