Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 13, 2026

Proposed changes

Added comprehensive test coverage for the existing feature that allows creating Variant objects from uint and uint[] with StatusCode TypeInfo. Tests verify that the Variant value can be properly cast to StatusCode or StatusCode[].

Test Coverage:

  • Scalar: new Variant(uint, TypeInfo.Scalars.StatusCode) → cast to StatusCode
  • Array: new Variant(uint[], TypeInfo.Arrays.StatusCode) → cast to StatusCode[]
  • Edge cases: empty arrays, single elements, various status code values (Good, BadNodeIdInvalid, custom codes)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Jan 13, 2026
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 2 commits January 13, 2026 11:31
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
Copilot AI changed the title [WIP] Allow status code variant creation from uint Add tests for StatusCode variant creation from uint Jan 13, 2026
Copilot AI requested a review from marcschier January 13, 2026 11:38
@marcschier marcschier merged commit 398ee0c into scvariant Jan 13, 2026
46 of 47 checks passed
@marcschier marcschier deleted the copilot/sub-pr-3472 branch January 13, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants