Skip to content

Conversation

@saumya1317
Copy link
Contributor

This pull request implements the Brightness Adjust filter (-B flag) for the image filtering application. It allows users to either increase or decrease the brightness of an image by providing an integer value with the flag. The filter and its usage are both implemented in code and described in the updated README.

Issues

Example:

Closes #17

@harshsankhla18 harshsankhla18 self-requested a review October 22, 2025 08:43
Copy link
Collaborator

@harshsankhla18 harshsankhla18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Just do one thing Solve only brightness adjust filter in this issue. And For Threshold filter add the description later when i assign you that in other PR. And Also Re-Send the separated PRs with brightness and then if no one Sends the PR then I will accept the threshold PR as you have enough contriubtions on this project already.

@saumya1317
Copy link
Contributor Author

okay i have removed threshold one addded brightness algo

@harshsankhla18
Copy link
Collaborator

@saumya1317 Correct your PR title to conventional commit title otherwise it will not pass the checks .

@saumya1317 saumya1317 changed the title brightness adjust feat(brightness): add brightness adjust filter (-B flag) Oct 22, 2025
@harshsankhla18 harshsankhla18 merged commit 0ced8f3 into OPCODE-Open-Spring-Fest:main Oct 22, 2025
5 of 8 checks passed
Copy link
Collaborator

@harshsankhla18 harshsankhla18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brightness filter is not working for gcc, though i have merged PR , please correct it for gcc and its use case should be "filter -B 40 input.bmp output.bmp" , your code is not working properly . Correct it fast otherwise you points will be deducted again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Brightness Adjust

2 participants