Skip to content

HYRAX-2077: Remove --enable-developer flag from bes_core Dockerfile build#1288

Merged
hannahilea merged 16 commits intomasterfrom
hr/HYRAX-2077-disable-developer
Apr 3, 2026
Merged

HYRAX-2077: Remove --enable-developer flag from bes_core Dockerfile build#1288
hannahilea merged 16 commits intomasterfrom
hr/HYRAX-2077-disable-developer

Conversation

@hannahilea
Copy link
Copy Markdown
Contributor

@hannahilea hannahilea commented Mar 31, 2026

Description

Reference ticket: HYRAX-2077

Tasks

  • Ticket exists and is linked in title
  • Tests added/updated
  • Dead code removed
  • No TODOs added

hannahilea
hannahilea commented Apr 2, 2026
View reviewed changes
Comment thread .travis.yml Outdated
@hannahilea hannahilea marked this pull request as draft April 2, 2026 16:59
@hannahilea hannahilea marked this pull request as ready for review April 2, 2026 19:51
jgallagher59701
jgallagher59701 approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The RHEL9 tests in the hdf5 handler are a bit of a mystery to me.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hannahilea
Copy link
Copy Markdown
Contributor Author

hannahilea commented Apr 3, 2026

Tested locally that new image successfully ran hyrax-regression tests when built into a hyrax-docker el-8 hyrax image.

@hannahilea
Copy link
Copy Markdown
Contributor Author

hannahilea commented Apr 3, 2026

(Attempted to run -test-deploy branch through the system, but due to a confluence of other builds going on, couldn't reliably see that through. Since the local test succeeded, I'm going to merge now; if it turns out this introduces an issue downstream we can revert it.)

@hannahilea hannahilea merged commit 8ee4e23 into master Apr 3, 2026
8 of 9 checks passed
@hannahilea hannahilea deleted the hr/HYRAX-2077-disable-developer branch April 3, 2026 17:12
@hannahilea hannahilea mentioned this pull request Apr 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgallagher59701 jgallagher59701 jgallagher59701 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannahilea @jgallagher59701