Support for merged patches for element norm output to VTF#881
Open
kmokstad wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
jenkins build this with downstream ifem-elasticity=226 please |
There was a problem hiding this comment.
Pull request overview
This PR extends VTF output so element-norm arrays can be written when mergeVtf is enabled by merging patch-level element norm data before expanding it to the refined visualization grid.
Changes:
- Update
ElementBlock::merge()to offset merged element IDs (to avoid collisions across merged patches). - Extend
SIMoutput::writeGlvN()with atimeparameter and implement merged-patch element norm output. - Minor refactors to reuse
myProblem->getSolution()references and update call sites for the newwriteGlvNsignature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Utility/ElementBlock.C |
Offsets element IDs when merging blocks to support unique element-ID mapping in merged VTF geometry. |
src/SIM/SIMoutput.h |
Updates writeGlvN signature to include time. |
src/SIM/SIMoutput.C |
Implements merged-patch element-norm output logic and refactors solution extraction to reuse patchSol. |
src/SIM/AdaptiveSIM.C |
Updates writeGlvN call to match the new signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1851
to
+1853
| // We need to merge the results for all patches before writing them | ||
| singleField.resize(nrow,ielx+nActElm); | ||
|
|
Comment on lines
+1888
to
+1889
| else | ||
| ielx += nActElm; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging the patch-level element norm arrays before expanding them to account for finer visualization grid.