Adding the ROE summary vector#4833
Conversation
vkip
added
the
manual:enhancement
|
jenkins build this please |
|
All test failures seem only due to the addition of the ROE summary vectors (ROE:1 and ROE:2) |
Agreed. I'll just double check some of the failures which had multiple hits for these. |
|
jenkins build this ignore_extra please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
All test failures seem only due to the addition of the ROE summary vectors (ROE:1 and ROE:2)
Agreed. I'll just double check some of the failures which had multiple hits for these.
Indeed, those are the only test failures so once we've addressed the defining expression of the efficiency factor I'll update the reference solutions.
|
|
||
| const auto initial = initial_inplace.get( region_name, Opm::Inplace::Phase::OIL, args.num ); | ||
| const auto current = args.inplace.get( region_name, Opm::Inplace::Phase::OIL, args.num ); | ||
| return { (initial - current) / current, measure::identity }; |
There was a problem hiding this comment.
This definition looks at little suspicious to me. Did you mean to divide by initial instead? In the limit as current tends to zero (full recovery), we'll get an efficiency factor approaching infinity and that's unlikely to be useful.
Moreover, since this is a per-region quantity, we should also guard against initial == 0 which could be the case in the gas cap or in the water zone.
There was a problem hiding this comment.
🤦♂️ Should be initial of course, and will check for zero. Thanks!
|
jenkins build this please |
|
|
||
| const auto initial = initial_inplace.get( region_name, Opm::Inplace::Phase::OIL, args.num ); | ||
| if (initial < 1.0e-15) | ||
| return 0.0; |
There was a problem hiding this comment.
This statement gives a build failure. I think you meant
return zero;instead.
There was a problem hiding this comment.
Yup, glad one of us is awake. Thanks again!
|
jenkins build this please |
|
jenkins build this update_data please |
Reason: PR OPM/opm-common#4833 opm-common = ca9701261c5beb55684eace70f4bc9d025d48758 opm-grid = a0c0fa539c264e9308e65795a9614bb11f2d5309 opm-simulators = ca9701261c5beb55684eace70f4bc9d025d48758 ### Changed Tests ### * gconprod_t1l * gconprod_t1w * gconprod_t2g * gconprod_t2o * base_wt_tracer * base_wt_tracer(restart) * 01_wgrupcon * 02_wgrupcon * 6_uda_model5_stdw * 6_uda_model5_stdw(restart)
|
jenkins build this opm-tests=1429 please |
Automatic Reference Data Update for PR OPM/opm-common#4833
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. This looks good to me now and as the new reference solutions have been installed on the CI system, I'll merge into master.
2 participants
No description provided.