Skip to content

Document SummaryConfig Class#4853

Merged
bska merged 1 commit into
OPM:masterfrom
bska:document-smrycfg-api
Dec 5, 2025
Merged

Document SummaryConfig Class#4853
bska merged 1 commit into
OPM:masterfrom
bska:document-smrycfg-api

Conversation

@bska
Copy link
Copy Markdown
Member

@bska bska commented Dec 4, 2025

This PR adds Doxygen-style documentation to the SummaryConfig and SummaryConfigNode classes and ancillary functions (comparison operators and keyword category/type parsers).

While here, also make the begin/end/size member functions inline in the SummaryConfig class since they're entirely trivial and remove the (long) unused member function SummaryConfig::wbp_wells().

@bska bska added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Dec 4, 2025
@bska
Copy link
Copy Markdown
Member Author

bska commented Dec 4, 2025

jenkins build this please

Copy link
Copy Markdown
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, spotted one typo.

Comment thread opm/input/eclipse/EclipseState/SummaryConfig/SummaryConfig.hpp Outdated
@bska bska force-pushed the document-smrycfg-api branch from 48204ef to 4a3d951 Compare December 5, 2025 10:46
@bska
Copy link
Copy Markdown
Member Author

bska commented Dec 5, 2025

Looks good, spotted one typo.

Good catch. That one was actually repeated elsewhere as well 🤦

I've pushed an update to address that and, additionally, document the (poorly named) handlerProcessingInstruction() member function as well. I'd forgotten about that member function in the first edition of this PR...

@bska
Copy link
Copy Markdown
Member Author

bska commented Dec 5, 2025

jenkins build this please

This commit adds Doxygen-style documentation to the SummaryConfig
and SummaryConfigNode classes and ancillary functions (comparison
operators and keyword category/type parsers).

While here, also make the begin/end/size member functions inline in
the SummaryConfig class since they're entirely trivial and remove
the (long) unused member function SummaryConfig::wbp_wells().
@bska bska force-pushed the document-smrycfg-api branch from 4a3d951 to 3a320d3 Compare December 5, 2025 11:29
@bska
Copy link
Copy Markdown
Member Author

bska commented Dec 5, 2025

jenkins build this please

@bska
Copy link
Copy Markdown
Member Author

bska commented Dec 5, 2025

PR approved and build check is green. I'll merge into master.

@bska bska merged commit 5db4f3e into OPM:master Dec 5, 2025
2 checks passed
@bska bska deleted the document-smrycfg-api branch December 5, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants