TUNINGDP keyword#4890
Merged
Merged
Conversation
- Note: different default whether TUNINGDP is set or not! - New event trigger for TUNINGDP
OPM exclusive options with default value 0, i.e. disabled.
akva2
added
the
manual:enhancement
akva2
reviewed
Jan 13, 2026
Member
|
please add TuningDp to test_Serialization.cpp |
Contributor
Author
Added now in the new update, thanks for the reminder! |
Member
|
jenkins build this opm-simulators=6723 please |
1 similar comment
Member
|
jenkins build this opm-simulators=6723 please |
totto82
reviewed
Jan 21, 2026
Member
totto82
left a comment
totto82
left a comment
There was a problem hiding this comment.
Thanks. Only one question about units on RS/RV that should be answered/fixed before merging.
| { | ||
| "name": "TRGDDRS", | ||
| "value_type": "DOUBLE", | ||
| "default": 0.0 |
Member
There was a problem hiding this comment.
Should not RS and RV have dimensions?
Member
|
jenkins build this opm-simulators=6723 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements parsing of the TUNINGDP keyword in the SCHEDULE section. The keyword sets tolerances for max. solution update changes requires for convergence. Note that there are separate default values depending on if TUNINGDP is present in the deck or not. Items for linear solver tolerances (TRGLCV and XXXLCV) are handled the same as in TUNING. A new event trigger for TUNINGDP is also implemented. Additionally, items for max. RS and RV changes have been implemented, which are OPM Flow specific items.
This PR is in draft mode for testing.