Skip to content

Accumulate satellite gaslift (support for GSATPROD item 6)#4892

Merged
bska merged 1 commit into
OPM:masterfrom
totto82:gsatprod6
Jan 15, 2026
Merged

Accumulate satellite gaslift (support for GSATPROD item 6)#4892
bska merged 1 commit into
OPM:masterfrom
totto82:gsatprod6

Conversation

@totto82
Copy link
Copy Markdown
Member

@totto82 totto82 commented Jan 12, 2026

No description provided.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Jan 12, 2026

jenkins build this please

@totto82 totto82 added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Jan 12, 2026
@totto82 totto82 marked this pull request as ready for review January 13, 2026 07:58
@totto82 totto82 requested a review from bska January 13, 2026 07:58
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Jan 13, 2026

@bska This only handles the summary part, as the restart part appears to already be in place.

Copy link
Copy Markdown
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the most part. I'd appreciate if there were at least one unit test demonstrating the effects of efficiency factors too. That way, we're more guarded against the issue that prompted PR #4683.

@bska
Copy link
Copy Markdown
Member

bska commented Jan 13, 2026

This only handles the summary part, as the restart part appears to already be in place.

Right. We added partial restart support in #4729. The biggest remaining issue is that we don't support UDAs in GSATPROD at simulation restart.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Jan 15, 2026

jenkins build this please

Copy link
Copy Markdown
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates. This looks good to me now and I'll merge into master.

@bska bska merged commit ddc6710 into OPM:master Jan 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants