Skip to content

Remove Unused ParseContext Member Functions#4900

Merged
bska merged 1 commit into
OPM:masterfrom
bska:remove-unused-memfn
Jan 16, 2026
Merged

Remove Unused ParseContext Member Functions#4900
bska merged 1 commit into
OPM:masterfrom
bska:remove-unused-memfn

Conversation

@bska
Copy link
Copy Markdown
Member

@bska bska commented Jan 16, 2026

If we later need to iterate over a ParseContext object, we can reintroduce the begin()/end() member function pair.

If we later need to iterate over a ParseContext object, we can
reintroduce the begin()/end() member function pair.
@bska bska added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Jan 16, 2026
@bska
Copy link
Copy Markdown
Member Author

bska commented Jan 16, 2026

As far as I can tell, the withKey() functions have never been used since initially introduced in commit 091dc19, originally OPM/opm-parser@6b5fea5f (PR OPM/opm-parser#770).

@bska
Copy link
Copy Markdown
Member Author

bska commented Jan 16, 2026

jenkins build this please

Copy link
Copy Markdown
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less dead code, more good.

@bska
Copy link
Copy Markdown
Member Author

bska commented Jan 16, 2026

PR approved and build check is green. I'll merge into master.

@bska bska merged commit 08200ee into OPM:master Jan 16, 2026
3 checks passed
@bska bska deleted the remove-unused-memfn branch January 16, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants