Report Missing SKIPREST Unless DATES Strictly Later Than Restart#4963
Merged
Conversation
bska
added
the
manual:enhancement
Member
Author
|
Note: I'm creating the PR in draft mode because it depends on, and contains, the earlier PR #4962. I will keep the PR in a draft state until such time as it is ready for review and merging. |
bska
force-pushed
the
rst-detect-missing-skiprest
branch
2 times, most recently
from
98d9f18 to
572b72e
Compare
Member
Author
|
jenkins build this please |
Issue a diagnostic about a potentially missing 'SKIPREST' keyword if any DATES record specifies a time that is not strictly later than the restart time. If a restarted run does not use SKIPREST, then all of its explicitly defined DATES must be strictly later than the restart time lest we have negative or zero time step sizes.
bska
force-pushed
the
rst-detect-missing-skiprest
branch
from
572b72e to
6f8c0f6
Compare
Contributor
|
Excellent, this has now been tested on a full field model in Equinor, and behaviour is as expected. |
Member
Author
Thank you so much for testing. Based on that feedback, I'm marking the PR as "ready for review" and I'm running a build check. |
Member
Author
|
jenkins build this please |
akva2
approved these changes
Feb 4, 2026
Member
Author
PR approved and build check is green. I'll merge into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue a diagnostic about a potentially missing
SKIPRESTkeyword if anyDATESrecord specifies a time that is not strictly later than the restart time. If a restarted run does not useSKIPREST, then all of its explicitly defined DATES must be strictly later than the restart time lest we have negative or zero time step sizes.This PR effectively tightens up the check introduced in #3035.