More hook usage#4969
Merged
Merged
Conversation
remove faulty comment about not finding the shared lib, build-tree objects always have RPATH set, and likewise remove setting of LD_LIBRARY_PATH
akva2
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
bska
approved these changes
Feb 4, 2026
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
let's get the trivial stuff out of the way.
Makes sense. Please merge when green and complete.
blattms
reviewed
Feb 4, 2026
| macro(${project}_install_hook) | ||
| # Install build system files and documentation | ||
| install(DIRECTORY cmake | ||
| DESTINATION share/opm USE_SOURCE_PERMISSIONS |
Member
There was a problem hiding this comment.
While you are touching this anyway, please use the variables from GNUInstallDirs.cmake. Here this would be ${CMAKE_INSTALL_DATADIR}/opm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move more stuff to appropriate hooks. Still more work to do here, but there is more disentangling needed, let's get the trivial stuff out of the way.