Skip to content

Skip the merge if no cells were added.#950

Merged
michal-toth merged 1 commit into
OPM:masterfrom
michal-toth:cleanup/zoltan-inplace_merge
Nov 20, 2025
Merged

Skip the merge if no cells were added.#950
michal-toth merged 1 commit into
OPM:masterfrom
michal-toth:cleanup/zoltan-inplace_merge

Conversation

@michal-toth
Copy link
Copy Markdown
Member

Some tests failed in the implace_merge. They use much stricter checking, so I could not reproduce that with a normal debug build.

The failures were caused by the implace_merge having no elements in the second half, which happens on all ranks except root. I verified that each half of myExportList and myImportList is sorted.

@michal-toth michal-toth added bug manual:irrelevant This PR is a minor fix and should not appear in the manual labels Nov 18, 2025
@michal-toth
Copy link
Copy Markdown
Member Author

jenkins build this serial please

@akva2
Copy link
Copy Markdown
Member

akva2 commented Nov 18, 2025

FYI, to reproduce you have to compile with -D_GLIBCXX_DEBUG. This is a little involved, as you have to build boost, dune and some other libs with the same setting. I have a script that builds the required stuff, I supplied it to @blattms

Since the runtime is close to 10 hours for this configuration I'm very hesitant to expose it through the trigger..
I'll test that this takes care of the problem locally.

@akva2
Copy link
Copy Markdown
Member

akva2 commented Nov 18, 2025

ack, runs through fine now.

@michal-toth michal-toth merged commit 2626558 into OPM:master Nov 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants