Chase API for Well Specification Report#6533
Merged
Merged
Conversation
bska
added
the
manual:irrelevant
Member
Author
|
This is the companion work to PR OPM/opm-common#4788 which changes the API. As the upstream PR is currently blocked, I am creating the PR in a draft state and will keep it as such until the pair of PRs is ready for review. |
bska
force-pushed
the
wlist-rptsched-welspecs
branch
7 times, most recently
from
0faf95b to
c120d05
Compare
Contributor
|
This has now been tested in Equinor Results and simulator behaviours are as expected and I'm looking forward to seeing this go into master. |
In particular, we now need to pass a flag that says whether or not any of the run's well lists have changed since the previous report step. If so, the well specification report will emit a sheet detailing the contents of all of the run's current well lists.
bska
force-pushed
the
wlist-rptsched-welspecs
branch
from
c120d05 to
d9881f3
Compare
Member
Author
|
The prerequisite PRs have all been merged into the master branch so I'm marking this PR as "ready for review". Quick reminder that this work must be reviewed and merged alongside its upstream companion PR, OPM/opm-common#4788. |
Member
Author
|
jenkins build this opm-common=4788 please |
akva2
approved these changes
Oct 20, 2025
Member
Author
|
PR approved and build check is green. I'll merge into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, we now need to pass a flag that says whether or not any of the run's well lists have changed since the previous report step. If so, the well specification report will emit a sheet detailing the contents of all of the run's current well lists.