Fix dangling reference in InjectionTargetCalculator#6719
Merged
Conversation
Store injection_phase by value instead of by reference to prevent dangling reference when the calculator is returned from a function. The previous code stored a const reference to the Phase parameter, which works when the calculator is constructed and used within the same scope (e.g., in GroupStateHelper::checkGroupConstraintsInj). However, when the calculator is returned from a e.g a function the temporary Phase value passed to the constructor is destroyed, leaving a dangling reference that can cause undefined behavior.
hakonhagland
added
the
manual:irrelevant
Contributor
Author
|
jenkins build this please |
Member
|
For what it's worth, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
injection_phaseby value instead of by reference to prevent dangling reference when the calculator is returned from a function.The previous code stored a const reference to the
Phaseparameter, which works when the calculator is constructed and used within the same scope (e.g., inGroupStateHelper::checkGroupConstraintsInj()). However, when the calculator is returned from a e.g a function the temporaryPhasevalue passed to the constructor is destroyed, leaving a dangling reference that can cause undefined behavior.