Skip to content

Reservoir coupling: Fix MPI synchronization in receiveGroupTargetsFromMaster()#6762

Merged
blattms merged 1 commit into
OPM:masterfrom
hakonhagland:fix_mpi_comm
Feb 4, 2026
Merged

Reservoir coupling: Fix MPI synchronization in receiveGroupTargetsFromMaster()#6762
blattms merged 1 commit into
OPM:masterfrom
hakonhagland:fix_mpi_comm

Conversation

@hakonhagland
Copy link
Copy Markdown
Contributor

Builds on #6761, which should be merged first.

Fix MPI synchronization in receiveGroupTargetsFromMaster(). In multi-rank slave processes, receiveGroupTargetsFromMaster() only received targets on rank 0, but the underlying receive functions contained MPI broadcasts that required all ranks to participate.

@hakonhagland hakonhagland added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Jan 25, 2026
@hakonhagland
Copy link
Copy Markdown
Contributor Author

jenkins build this please

@bska
Copy link
Copy Markdown
Member

bska commented Jan 26, 2026

Builds on #6761, which should be merged first.

Okay. In that case, I'll put the PR into a draft state to avoid inadvertent merging.

@blattms
Copy link
Copy Markdown
Member

blattms commented Jan 27, 2026

Other PR is merged. Please rebase for easier reviewing and ping me

In multi-rank slave processes, receiveGroupTargetsFromMaster() was only
called by rank 0, but the underlying receive functions contain MPI broadcasts
that require ALL ranks to participate.
@hakonhagland
Copy link
Copy Markdown
Contributor Author

jenkins build this please

@hakonhagland hakonhagland marked this pull request as ready for review January 27, 2026 12:40
@blattms blattms merged commit 8b3ee3b into OPM:master Feb 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants