Reservoir coupling: Fix MPI synchronization in receiveGroupTargetsFromMaster()#6762
Merged
Conversation
Contributor
Author
|
jenkins build this please |
Member
Okay. In that case, I'll put the PR into a draft state to avoid inadvertent merging. |
Member
|
Other PR is merged. Please rebase for easier reviewing and ping me |
In multi-rank slave processes, receiveGroupTargetsFromMaster() was only called by rank 0, but the underlying receive functions contain MPI broadcasts that require ALL ranks to participate.
f7d6f53 to
05b89a0
Compare
Contributor
Author
|
jenkins build this please |
blattms
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #6761, which should be merged first.
Fix MPI synchronization in
receiveGroupTargetsFromMaster(). In multi-rank slave processes,receiveGroupTargetsFromMaster()only received targets on rank 0, but the underlying receive functions contained MPI broadcasts that required all ranks to participate.