Skip to content

BVEL[G|O|W][I|J|K][|-] summary keywords#6830

Merged
daavid00 merged 1 commit into
OPM:masterfrom
daavid00:bvels
Feb 19, 2026
Merged

BVEL[G|O|W][I|J|K][|-] summary keywords#6830
daavid00 merged 1 commit into
OPM:masterfrom
daavid00:bvels

Conversation

@daavid00
Copy link
Copy Markdown
Member

@daavid00 daavid00 commented Feb 13, 2026

Depends on OPM/opm-common#4989

Before merging, in order to add to the test the implementation, updating the data in OPM/opm-tests#1492

@daavid00 daavid00 added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Feb 13, 2026
Comment thread opm/simulators/flow/FlowsContainer.cpp Outdated
if (summaryConfig.keywords("BVEL*").size() > 0) {
const std::array<int, 3> phaseIdxs { gasPhaseIdx, oilPhaseIdx, waterPhaseIdx };
const std::array<int, 3> compIdxs { gasCompIdx, oilCompIdx, waterCompIdx };
const std::string nameIdxs[3] { "G", "O", "W" };
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why suddenly 2 C arrays?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, I have updated the PR, thanks :).

@daavid00 daavid00 marked this pull request as draft February 13, 2026 15:14
@daavid00 daavid00 marked this pull request as ready for review February 13, 2026 17:06
@daavid00 daavid00 marked this pull request as draft February 14, 2026 10:47
@daavid00
Copy link
Copy Markdown
Member Author

The last commit fixed an issue for two-phase flow, marking this as ready to review

@daavid00 daavid00 marked this pull request as ready for review February 14, 2026 13:01
@daavid00 daavid00 requested a review from bska February 18, 2026 08:19
Copy link
Copy Markdown
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Please rebase and squash before merging.

@daavid00
Copy link
Copy Markdown
Member Author

jenkins build this please

1 similar comment
@daavid00
Copy link
Copy Markdown
Member Author

jenkins build this please

@daavid00
Copy link
Copy Markdown
Member Author

jenkins build this opm-tests=1492 update_data please

1 similar comment
@daavid00
Copy link
Copy Markdown
Member Author

jenkins build this opm-tests=1492 update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Feb 19, 2026
        PR OPM#1492

Reason: PR OPM/opm-simulators#6830
        PR OPM#1492

opm-common     = 898db9f18b2b089ec7daae9a1519c279ccaa1a1d
opm-grid       = 9320dca9671f6898a92a009182b6f80ad429b27a
opm-simulators = 3bf4955f003e0c97017bfed144af7ebc68b06931

### Changed Tests ###

  * rxft_smry
  * spe1case1_water
  * co2store_gw
@daavid00
Copy link
Copy Markdown
Member Author

jenkins build this opm-tests=1492 please

@daavid00 daavid00 merged commit 0eace1f into OPM:master Feb 19, 2026
2 checks passed
@daavid00 daavid00 deleted the bvels branch February 19, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants