BVEL[G|O|W][I|J|K][|-] summary keywords#6830
Merged
Merged
Conversation
akva2
reviewed
Feb 13, 2026
| if (summaryConfig.keywords("BVEL*").size() > 0) { | ||
| const std::array<int, 3> phaseIdxs { gasPhaseIdx, oilPhaseIdx, waterPhaseIdx }; | ||
| const std::array<int, 3> compIdxs { gasCompIdx, oilCompIdx, waterCompIdx }; | ||
| const std::string nameIdxs[3] { "G", "O", "W" }; |
Member
Author
There was a problem hiding this comment.
Ups, I have updated the PR, thanks :).
Member
Author
|
The last commit fixed an issue for two-phase flow, marking this as ready to review |
bska
approved these changes
Feb 19, 2026
Member
bska
left a comment
There was a problem hiding this comment.
Okay. Please rebase and squash before merging.
Member
Author
|
jenkins build this please |
1 similar comment
Member
Author
|
jenkins build this please |
Member
Author
|
jenkins build this opm-tests=1492 update_data please |
1 similar comment
Member
Author
|
jenkins build this opm-tests=1492 update_data please |
jenkins4opm
pushed a commit
to jenkins4opm/opm-tests
that referenced
this pull request
Feb 19, 2026
PR OPM#1492 Reason: PR OPM/opm-simulators#6830 PR OPM#1492 opm-common = 898db9f18b2b089ec7daae9a1519c279ccaa1a1d opm-grid = 9320dca9671f6898a92a009182b6f80ad429b27a opm-simulators = 3bf4955f003e0c97017bfed144af7ebc68b06931 ### Changed Tests ### * rxft_smry * spe1case1_water * co2store_gw
Member
Author
|
jenkins build this opm-tests=1492 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OPM/opm-common#4989
Before merging, in order to add to the test the implementation, updating the data in OPM/opm-tests#1492