make FLOW_INSTANTIATE_FLOAT a private compile definition#6945
Merged
Conversation
only used in cpp files and two header files. neither of these header files are part of any public interface, so mark them private. while this means downstreams cannot detect if the library was built with float support, they will certainly notice the linking errors. should this become a problem, we can easily move it to public
akva2
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
bska
approved these changes
Mar 17, 2026
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Okay, let's gain some experience with this approach. I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only used in cpp files and two header files. neither of these header files are part of any public interface, so mark them private.
while this means downstreams cannot detect if the library was built with float support, they will certainly notice the linking errors. should this become a problem, we can easily move it to public