Safeguard against running TPSA simulations without FlowProblemTPSA#6985
Merged
bska merged 1 commit intoOPM:masterfrom Apr 15, 2026
Merged
Safeguard against running TPSA simulations without FlowProblemTPSA#6985bska merged 1 commit intoOPM:masterfrom
bska merged 1 commit intoOPM:masterfrom
Conversation
svenn-t
added
the
manual:bugfix
Contributor
Author
|
jenkins build this please |
akva2
reviewed
Apr 14, 2026
| const auto& rspec = vanguard.eclState().runspec(); | ||
| if (rspec.mech() && rspec.mechSolver().tpsa()) { | ||
| throw std::runtime_error("TPSA solver enabled in the deck, but geomechanics " | ||
| "module disabled at compile time!"); |
Contributor
Author
There was a problem hiding this comment.
thanks, I took the liberty of fixing my typo for the GEOCHEM throw as well.
akva2
approved these changes
Apr 15, 2026
Member
|
PR approved and build check is green. I'll merge into master. |
michal-toth
pushed a commit
to michal-toth/opm-simulators
that referenced
this pull request
Apr 17, 2026
Safeguard against running TPSA simulations without FlowProblemTPSA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, a simulation with TPSA in the deck will run even if a flow binary does not exist for the particular setup.