-
Notifications
You must be signed in to change notification settings - Fork 29
Adding plotting script for ArborX query order #538
Conversation
Co-authored-by: Damien L-G <dalg24@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have placed it in packages/Search/example/viz/ and added a requirements.txt that lists docopt, matplotlib, and numpy. No strong opinion on this though. I think it's good we finally start putting these scripts under version control. I just never was sure where would be most appropriate.
Note that now that #535 made it into master, it is trivial to implement a new visitor that output the matrix directly in the format you like instead of parsing the ones in DOT format.
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 96.11% 96.11% +<.01%
==========================================
Files 130 130
Lines 9516 9517 +1
==========================================
+ Hits 9146 9147 +1
Misses 370 370
Continue to review full report at Codecov.
|
dalg24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it is still a draft but I'd like request that me or someone other than Andrey post in the conversation one image produced by the script before we accept theses changes.
|
@dalg24 I assume that in the container one is able to run only saving to file, and not in display mode, correct? |
I only saved the plot. In principle I think it is possible if you run your container with |

Co-authored-by: Damien L-G dalg24@gmail.com
Not sure where to put it, so it's in
scriptsfor now. I would like to carry it with the repo so it could be used anytime without access to Jupyter.There are some quality of life improvements compared to original @dalg24's version:
Right now, there is no test for it, but I could add it if considered useful. For example, I could add a test for visualization driver to dump data, and run the script just to make sure it runs.