Staging

[JoshuaSBrown]

Summary by Sourcery

Bug Fixes:

• Ensure schema creation requests append a :0 version suffix when no version is provided in the ID to align behavior across implementations.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds automatic ":0" version suffix to schema IDs without an explicit version when handling /api/sch/create requests, aligning Node web service behavior with Python CommandLib.

Sequence diagram for /api/sch/create schema ID version normalization

sequenceDiagram
    actor Client
    participant WebServer
    participant SchemaService

    Client->>WebServer: POST /api/sch/create (body.id may lack version)
    WebServer->>WebServer: validate_schema_id
    alt id_has_no_version_suffix
        WebServer->>WebServer: body.id = body.id + :0
    else id_already_has_version
        WebServer->>WebServer: keep body.id unchanged
    end
    WebServer->>SchemaService: SchemaCreateRequest(body)
    SchemaService-->>WebServer: SchemaCreateReply
    WebServer-->>Client: JSON reply

Loading

Flow diagram for schema ID :0 suffix handling in /api/sch/create

flowchart TD
    A[Receive POST /api/sch/create] --> B[Read body.id]
    B --> C{Is body.id set?}
    C -- No --> D[Proceed without id modification]
    C -- Yes --> E{Does body.id contain colon}
    E -- Yes --> F[Keep body.id unchanged]
    E -- No --> G[Set body.id = body.id + :0]
    D --> H[Send SchemaCreateRequest]
    F --> H
    G --> H
    H --> I[Return JSON reply to client]

Loading

File-Level Changes

Change	Details	Files
Normalize schema IDs on create by appending a default :0 version suffix when no version is provided.	Before sending SchemaCreateRequest, check if request body has an id field and whether it lacks a colon-delimited version segment. If the id has no colon, mutate the request body in-place to append ':0' to the id value. Leave the rest of the SchemaCreateRequest handling (sendMessage and response behavior) unchanged.	web/datafed-ws.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• Consider guarding the new logic with a type check (e.g., typeof a_req.body.id === 'string') to avoid runtime errors if id is not a string.
• If a_req.body is reused downstream (e.g., for logging or other handlers), you may want to avoid mutating it directly and instead construct a new payload with the normalized id when calling sendMessage.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider guarding the new logic with a type check (e.g., `typeof a_req.body.id === 'string'`) to avoid runtime errors if `id` is not a string.
- If `a_req.body` is reused downstream (e.g., for logging or other handlers), you may want to avoid mutating it directly and instead construct a new payload with the normalized `id` when calling `sendMessage`.

## Individual Comments

### Comment 1
<location path="web/datafed-ws.js" line_range="1887" />
<code_context>

 app.post("/api/sch/create", (a_req, a_resp) => {
+    // Mirror Python CommandLib: ensure :0 version suffix on create
+    if (a_req.body.id && a_req.body.id.indexOf(":") === -1) {
+        a_req.body.id = a_req.body.id + ":0";
+    }
</code_context>
<issue_to_address>
**issue (bug_risk):** Guard against non-string `id` values before calling `.indexOf` to avoid runtime errors.

If `a_req.body.id` might be non-string (e.g., numeric from the client), `.indexOf` will throw. You can narrow to strings to avoid that:

```js
if (typeof a_req.body.id === "string" && a_req.body.id.indexOf(":") === -1) {
  a_req.body.id = a_req.body.id + ":0";
}
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Guard against non-string id values before calling .indexOf to avoid runtime errors.

If a_req.body.id might be non-string (e.g., numeric from the client), .indexOf will throw. You can narrow to strings to avoid that:

if (typeof a_req.body.id === "string" && a_req.body.id.indexOf(":") === -1) {
  a_req.body.id = a_req.body.id + ":0";
}