Skip to content

Bug fix: OPFLOW_LINEFLOW_PENALTY#11

Merged
pelesh merged 2 commits intodevelopfrom
nicholson/fix-lineflow-test
Mar 23, 2026
Merged

Bug fix: OPFLOW_LINEFLOW_PENALTY#11
pelesh merged 2 commits intodevelopfrom
nicholson/fix-lineflow-test

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Mar 23, 2026

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This fixes a bug where out-of-bound values were being added to the inequality constraint Jacobian.
The location is being accessed at

loc = line->startxslackloc;

so incorrectly setting it at

line->startxslackloc = loc;

Linked Issue(s)
See also this issue.

@nkoukpaizan nkoukpaizan requested a review from pelesh March 23, 2026 19:05
@nkoukpaizan nkoukpaizan self-assigned this Mar 23, 2026
@nkoukpaizan nkoukpaizan marked this pull request as ready for review March 23, 2026 19:12
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for OPFLOW_LINEFLOW_PENALTY now passes.

@pelesh pelesh merged commit c686901 into develop Mar 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants