A placeholder for implementing Jacobian unit tests.#33
Merged
pelesh merged 6 commits intoApr 15, 2026
Conversation
Collaborator
Author
|
@nkoukpaizan @PhilipFackler : I need a little help here. Tests pass for me on Frontier and on my laptop, however they fail in CI pipeline. I'm not sure I understand what I am doing wrong :/ |
nkoukpaizan
reviewed
Apr 14, 2026
PhilipFackler
approved these changes
Apr 15, 2026
Collaborator
PhilipFackler
left a comment
PhilipFackler
left a comment
There was a problem hiding this comment.
Looks good, helpful starting point.
nkoukpaizan
pushed a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
Creates a placeholder for unit tests for equality and inequality Jacobians for OPFLOW module. Test are documented and build structure is in place. Implementing those tests is out of scope of this PR.