Initial implementation of generic phasor dynamics app#359
Conversation
pelesh
left a comment
There was a problem hiding this comment.
Looks good as is. A couple of things to address before we merge:
- Please add a README file explaining solver configuration input. A skeletal document is sufficient as I expect @abirchfield will want to add more features to that.
- Please make sure CI tests pass (see comment below).
|
This is a great addition and an important step, so I had a lot of feedback. I had enough edits that I opened PR #363 on this branch (apologies if I did that incorrectly). I added various safety checks and extended the |
Thanks for the feedback @lukelowry, I responded in your PR. |
…test with ThreeBusBasic case
a2ca08d to
d7a8214
Compare
d7a8214 to
af8d3eb
Compare
pelesh
left a comment
There was a problem hiding this comment.
Looks good.
Please move directory GridKit/Apps --> application (same level as `GridKit dir). Applications are not part of the GridKit proper but rather built on top of GridKit library.
Description
This is a start on a generalized phasor dynamics app.
Closes #349
Proposed changes
This PR introduces the executable target
pdsim, the source for which is under GridKit/Apps/PhasorDynamics. It is based on the ThreeBusBasic example and includes event types relevant to that example using the proposed parameterized study input file from #349. I also added tests for this app based on the TwoBusBasic and ThreeBusBasic examples.Checklist
-Wall -Wpedantic -Wconversion -Wextra.