Skip to content

Initial implementation of generic phasor dynamics app#359

Merged
pelesh merged 3 commits intodevelopfrom
PhilipFackler/generic_pdsim
Apr 8, 2026
Merged

Initial implementation of generic phasor dynamics app#359
pelesh merged 3 commits intodevelopfrom
PhilipFackler/generic_pdsim

Conversation

@PhilipFackler
Copy link
Copy Markdown
Collaborator

@PhilipFackler PhilipFackler commented Apr 2, 2026

Description

This is a start on a generalized phasor dynamics app.

Closes #349

Proposed changes

This PR introduces the executable target pdsim, the source for which is under GridKit/Apps/PhasorDynamics. It is based on the ThreeBusBasic example and includes event types relevant to that example using the proposed parameterized study input file from #349. I also added tests for this app based on the TwoBusBasic and ThreeBusBasic examples.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as is. A couple of things to address before we merge:

  • Please add a README file explaining solver configuration input. A skeletal document is sufficient as I expect @abirchfield will want to add more features to that.
  • Please make sure CI tests pass (see comment below).

@pelesh pelesh added the enhancement New feature or request label Apr 6, 2026
@lukelowry
Copy link
Copy Markdown
Collaborator

This is a great addition and an important step, so I had a lot of feedback. I had enough edits that I opened PR #363 on this branch (apologies if I did that incorrectly).

I added various safety checks and extended the study format. Please let me know what you think and perhaps it can be merged into this PR. Thank you

@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Apr 7, 2026

This is a great addition and an important step, so I had a lot of feedback. I had enough edits that I opened PR #363 on this branch (apologies if I did that incorrectly).

I added various safety checks and extended the study format. Please let me know what you think and perhaps it can be merged into this PR. Thank you

Thanks for the feedback @lukelowry, I responded in your PR.

@lukelowry lukelowry mentioned this pull request Apr 8, 2026
7 tasks
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/generic_pdsim branch 2 times, most recently from a2ca08d to d7a8214 Compare April 8, 2026 17:02
@PhilipFackler PhilipFackler marked this pull request as ready for review April 8, 2026 17:02
@PhilipFackler PhilipFackler force-pushed the PhilipFackler/generic_pdsim branch from d7a8214 to af8d3eb Compare April 8, 2026 17:10
@PhilipFackler PhilipFackler requested a review from pelesh April 8, 2026 17:22
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please move directory GridKit/Apps --> application (same level as `GridKit dir). Applications are not part of the GridKit proper but rather built on top of GridKit library.

@pelesh pelesh merged commit e0d57b6 into develop Apr 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command line interface for gridkit to run a parameterized study

3 participants