Skip to content

Github actions#36

Merged
pelesh merged 17 commits intodevelopfrom
nicholson/buildsystem
Dec 17, 2024
Merged

Github actions#36
pelesh merged 17 commits intodevelopfrom
nicholson/buildsystem

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Dec 11, 2024 •
edited by pelesh
Loading

Use GitHub actions to set up basic testing for GridKit: Run all GridKit examples on pull request.

@nkoukpaizan nkoukpaizan self-assigned this Dec 11, 2024
@pelesh pelesh self-requested a review December 11, 2024 20:53
@pelesh pelesh added the testing label Dec 11, 2024
@pelesh
Copy link
Collaborator

pelesh commented Dec 12, 2024

The last commit 7491446 seemed to work fine. @nkoukpaizan did you rebase to latest develop? There was a bug getting false negatives to "scale microgrid" test, which was fixed in #30.

@pelesh pelesh force-pushed the nicholson/buildsystem branch from 7491446 to 74c0c8f Compare December 12, 2024 14:11
@nkoukpaizan
Spack submodule.
a77a8d1
@nkoukpaizan
Locally added Gridkit Spack package to the submodule.
700698a
@nkoukpaizan
Attempt at adapting Re::Solve's Github action for a basic build and t…
ebbe2b8 
…est.
@nkoukpaizan
Point Spack submodule to my fork, so it can be cloned in CI.
db3b7b1
@nkoukpaizan
Fix incorrect setup of Spack submodule.
77143be
@nkoukpaizan
Temporarily build the nicholson/buildsystem branch in CI, rather than…
600ccf7 
… develop.
@nkoukpaizan
Fix Spack path in Github action configuration file.
197cae7
@nkoukpaizan
Back to building gridkit@develop. Hack is done within the Spack package.
a8d92d7
@nkoukpaizan
Explicitly set ipopt+mumps~coinhsl in Github action configuration.
86f02e6
@nkoukpaizan
Temporarilly 'spack clean ipopt' in Github actions.
4958e23
@nkoukpaizan
Github actions configuration bug fix.
180b118
@nkoukpaizan
Update local Spack submodule.
d039bc1
@nkoukpaizan
Setting ipopt spec in Gridkit Spack package should be sufficient if c…
4a156e0 
…orrectly updated.
@nkoukpaizan
Update local Spack submodule.
da4ee4b
@nkoukpaizan
Update local Spack submodule.
43878d0
@nkoukpaizan nkoukpaizan force-pushed the nicholson/buildsystem branch from 74c0c8f to 43878d0 Compare December 12, 2024 14:41
@nkoukpaizan
Copy link
Collaborator Author

nkoukpaizan commented Dec 12, 2024

Rebased, but that test is still failing in CI. I will investigate.

@nkoukpaizan
Copy link
Collaborator Author

nkoukpaizan commented Dec 12, 2024

Another limitation is that I currently have Ipopt support turned off. I don't know if there's a way to provide the CoinHSL archive for ipopt+coinhsl~mumps through Github actions. And all hell breaks loose with the alternative ipopt~coinhsl+mumps (need to build MPI and link with MPI within Gridkit as well).

@nkoukpaizan nkoukpaizan marked this pull request as ready for review December 12, 2024 15:31
@pelesh
Copy link
Collaborator

pelesh commented Dec 17, 2024

@nkoukpaizan, I suggest commenting out failing test and ready this PR for the merge. The failing test is fixed in #37. I suggest merging this PR first.

@nkoukpaizan
Copy link
Collaborator Author

nkoukpaizan commented Dec 17, 2024

Commented out the failing test, and everything else is working. Should be ready to merge.

pelesh
pelesh approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good starting point for CI testing.

@pelesh pelesh merged commit aed675a into develop Dec 17, 2024
2 checks passed
@nkoukpaizan nkoukpaizan deleted the nicholson/buildsystem branch January 22, 2025 17:52
pelesh pushed a commit that referenced this pull request Apr 14, 2025
@nkoukpaizan @pelesh
Github actions (#36)
c152d58 
* Spack submodule.

* Locally added Gridkit Spack package to the submodule.

* Point Spack submodule to my fork, so it can be cloned in CI.

* Setting ipopt spec in Gridkit Spack package should be sufficient if correctly updated.

* Temporarilly commented out ScaleMicrogrid test.

* Removed test_install step from Github actions.
@pelesh pelesh mentioned this pull request Aug 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelesh pelesh pelesh approved these changes

Assignees

@nkoukpaizan nkoukpaizan

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nkoukpaizan @pelesh