Initial implementation of multi-contingency app#394
Open
PhilipFackler wants to merge 2 commits intodevelopfrom
Open
Initial implementation of multi-contingency app#394PhilipFackler wants to merge 2 commits intodevelopfrom
PhilipFackler wants to merge 2 commits intodevelopfrom
Conversation
Collaborator
|
'ContingencyStudy' -> 'CTGStudy' CTG is common short hand and way easier to type! One option. |
Collaborator
Author
|
yes, I need feedback on naming things |
Collaborator
|
A few comments:
|
e30ce37 to
463644f
Compare
463644f to
e49c57f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored
pdsimcode asContingencyStudyclass and reused in initial implementation of concurrent contingency app.Closes #392
Proposed changes
For the work-in-progress I implemented three different versions of the simulation for easy timing comparison.
The easiest interesting case to try locally is "new england" (I have 22 cores in my laptop).
Checklist
-Wall -Wpedantic -Wconversion -Wextra.