Fixes input file issue with parameter estimation example#44
Merged
Conversation
- Crashes for file IO when invalid - ParameterEstimation can be run not in directoy without error
pelesh
force-pushed
the
slaven/example_io_fix
branch
from
5bc9985 to
fb3e73e
Compare
reid-g
suggested changes
Jan 21, 2025
Collaborator
reid-g
left a comment
reid-g
left a comment
There was a problem hiding this comment.
Overall, looks good. Only some minor changes then it is good to go.
reid-g
approved these changes
Jan 21, 2025
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Fix for file IO in arbitrary directory - Crashes for file IO when invalid - ParameterEstimation can be run not in directoy without error * setLookupTable takes istream instead of filename as input. * Parameter estimation example input is from string, not file. --------- Co-authored-by: Reid Gomillion <rjg18@vt.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter estimation example crashes when input file cannot be found. Use a string to pretend to be a file in this example, so it can be run as a standalone binary without special input files. User still can easily modify this file to create their own app.
In this PR:
setLookupTablefunction takesstd::istreamand not input file name as the input. It is user's responsibility to create anstd::istream.