Skip to content

add graph modules to support unstructured data#23

Merged
pzhanggit merged 7 commits intoORNL:mainfrom
pzhanggit:dev-graph
Jan 23, 2026
Merged

add graph modules to support unstructured data#23
pzhanggit merged 7 commits intoORNL:mainfrom
pzhanggit:dev-graph

Conversation

@pzhanggit
Copy link
Copy Markdown
Collaborator

This PR is to extend support for unstructured data, which is often seen in simulations.

  • add an airfoil dataset example from deepmind, showing how to convert unstructured data into PyG graph Data objects
  • Extended multidataset object to support PyG Data objects
  • Extend SViT, ViT, and TurbT (with only one level for now) to support graph input data
  • Add config examples for testing

@pzhanggit pzhanggit requested review from TsChala and aprokop January 22, 2026 15:30
Copy link
Copy Markdown
Collaborator

@aprokop aprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, still need to go through models and graph_datasets.py

Few questions:

  • How did you choose what configs to include? For example, the difference between Demo_graph_vit.yaml and Demo_graph_svit.yaml is the usual differnce between ViT and SViT.
  • Is there something special in submit_batch_graph.sh that is not covered by other examples we have?

@pzhanggit
Copy link
Copy Markdown
Collaborator Author

Partial review, still need to go through models and graph_datasets.py

Few questions:

  • How did you choose what configs to include? For example, the difference between Demo_graph_vit.yaml and Demo_graph_svit.yaml is the usual differnce between ViT and SViT.
  • Is there something special in submit_batch_graph.sh that is not covered by other examples we have?

Re configs, this PR provides graph supports for all different models that are possible and includes the corresponding configs.

Not sure what's the question about on submit_batch_graph.sh.

Copy link
Copy Markdown
Collaborator

@TsChala TsChala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a bunch of test (MW_vit, flow3D, SOLPS with the leadtime fix, graph) and all of them worked. fine The SR test didn't work, the forward of turbt is not updated with opts.

@pzhanggit
Copy link
Copy Markdown
Collaborator Author

I tried a bunch of test (MW_vit, flow3D, SOLPS with the leadtime fix, graph) and all of them worked. fine The SR test didn't work, the forward of turbt is not updated with opts.

Thanks! I've addressed your comments. @TsChala let me know if you have more comments.

Copy link
Copy Markdown
Collaborator

@TsChala TsChala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the fixes, it looks good to me!

@pzhanggit pzhanggit merged commit 61d1dc0 into ORNL:main Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants