add graph modules to support unstructured data#23
Conversation
aprokop
left a comment
There was a problem hiding this comment.
Partial review, still need to go through models and graph_datasets.py
Few questions:
- How did you choose what configs to include? For example, the difference between
Demo_graph_vit.yamlandDemo_graph_svit.yamlis the usual differnce between ViT and SViT. - Is there something special in
submit_batch_graph.shthat is not covered by other examples we have?
Re configs, this PR provides graph supports for all different models that are possible and includes the corresponding configs. Not sure what's the question about on |
TsChala
left a comment
There was a problem hiding this comment.
I tried a bunch of test (MW_vit, flow3D, SOLPS with the leadtime fix, graph) and all of them worked. fine The SR test didn't work, the forward of turbt is not updated with opts.
Thanks! I've addressed your comments. @TsChala let me know if you have more comments. |
TsChala
left a comment
There was a problem hiding this comment.
After the fixes, it looks good to me!
This PR is to extend support for unstructured data, which is often seen in simulations.