Feature/update create#20
Merged
Merged
Conversation
added 11 commits
April 13, 2026 13:29
sempervent
requested changes
Apr 15, 2026
Contributor
sempervent
left a comment
sempervent
left a comment
There was a problem hiding this comment.
A few comments and then we can merge this in. Also need to add this to the CHANGELOG.md and describe it there.
Comment on lines
+67
to
+73
| # TODO: implement time data parsing and call self.send_time_data(df, reference_type) | ||
| # or self.send_data(df, metric_type, reference_type) | ||
| # df = pd.DataFrame({"time": [...], "value": [...]}) | ||
| # self.send_time_data(df, reference_type=...) | ||
|
|
||
| # Ensure the format it is reading in matches that in save_to_file | ||
| raise NotImplementedError |
Contributor
There was a problem hiding this comment.
where does df come from, I don't see it in the signature and it's not fully explained if it is part of self or if it is loaded as a df from the init
Contributor
Author
There was a problem hiding this comment.
The user has to create it, from the input_file... I thought the line showing df = pd.DataFrame would make that pretty clear. I'll try to reword and add think on a better example...
sempervent
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating random and collect mixins, factoring the logic out to those.
Updating the create functionality to reflect current practices.