Skip to content

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Sep 4, 2025

Description

hykkt_spgemm_test was failing on Frontier due to the use of an older version of ROCm. According to the current README for HyKKT, ROCm >= 6.4 is needed.

Proposed changes

Upgraded the Frontier buildsystem to use rocm/6.4.1 and rebuilt the dependencies accordingly.

Checklist

  • All tests pass. Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows Re::Solve style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

This only affects the Frontier buildsystem.

@nkoukpaizan nkoukpaizan self-assigned this Sep 4, 2025
@nkoukpaizan nkoukpaizan changed the title Upgrade Frontier buildsystem to rocm/6.4.1 (>6.4 needed for hykkt spg… Upgrade Frontier buildsystem to rocm/6.4.1 Sep 4, 2025
Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass.
I ran source buildsystem/frontier-env.sh from the main ReSolve directory.

@shakedregev shakedregev merged commit 694ef4c into hykkt-dev Sep 4, 2025
6 checks passed
@shakedregev shakedregev deleted the nicholson/hykkt-dev-frontier-buildsystem branch September 4, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants