Fix potential failure in make test_install#434
Merged
Conversation
If make install was not called, then make test_install will fail. This fix ensures make install is always called before make_test install.
tamar-dewilde
approved these changes
Jun 4, 2026
Collaborator
tamar-dewilde
left a comment
tamar-dewilde
left a comment
There was a problem hiding this comment.
I tested this with fresh CPU, CUDA, and HIP builds by running test_install without manually running install first. All three passed with local CMAKE_INSTALL_PREFIX values, and the fix looks correct to me.
andrewxu319
approved these changes
Jun 4, 2026
Collaborator
andrewxu319
left a comment
andrewxu319
left a comment
There was a problem hiding this comment.
This works on a clean CPU/CUDA build. Called make test_install without make install.
Collaborator
|
Tested and it works. Nice clean fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
make test_installis called beforemake installcall, the test will fail giving misleading feedback that something is wrong with the installation configuration. See e.g. #428Proposed changes
Enforce installation as a part of the target
test_install. One-line fix suggested.Checklist
make testandmake test_installper testing instructions). Code tested on./examples/<your_example>.exe -hto get instructions how to run examples). Code tested on:-Wall -Wpedantic -Wconversion -Wextra.Further comments