Skip to content

Handling of webform type#13

Closed
rimi-itk wants to merge 2 commits intoOS2Forms:developfrom
rimi-itk:feature/webform-type
Closed

Handling of webform type#13
rimi-itk wants to merge 2 commits intoOS2Forms:developfrom
rimi-itk:feature/webform-type

Conversation

@rimi-itk
Copy link
Copy Markdown
Collaborator

Pre-population of webform fields should only happen when webform type, i.e. “personal” or “company”, is actually set on the form.

  • Cleaned up handling of webform_type setting
  • Pre-populated fields only when webform type is set

@rimi-itk rimi-itk marked this pull request as ready for review July 20, 2021 14:10
@andriyun andriyun requested a review from stankut August 3, 2021 07:47
@stankut
Copy link
Copy Markdown
Collaborator

stankut commented Aug 11, 2021

After discussion with @skifter it is decided to leave this PR unmerged.

Setting the form type (personal/company) has always been an option, which some of the customer are not aware of (because they don't really need it with their current set up).
However the same customers actively use NemID fields (for both person and company) and expect them to work the same way as they do now.

As PR is suggsting, making the form type selection a mandatory process (without which the form prepopulate will no longer work) would mean an additional step in the workflow without any obvious gain.

AS IS form works fine with both types of NemID fields - personal/company. After logging in, the irrelevant ones will be hidden.

@stankut stankut closed this Aug 11, 2021
jekuaitk added a commit that referenced this pull request Mar 27, 2026
…-post

Feature/sender address in digital post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants