Handling of webform type#13
Closed
rimi-itk wants to merge 2 commits intoOS2Forms:developfrom
rimi-itk:feature/webform-type
Closed
Handling of webform type#13rimi-itk wants to merge 2 commits intoOS2Forms:developfrom rimi-itk:feature/webform-type
rimi-itk wants to merge 2 commits intoOS2Forms:developfrom
rimi-itk:feature/webform-type
Conversation
Collaborator
|
After discussion with @skifter it is decided to leave this PR unmerged. Setting the form type (personal/company) has always been an option, which some of the customer are not aware of (because they don't really need it with their current set up). As PR is suggsting, making the form type selection a mandatory process (without which the form prepopulate will no longer work) would mean an additional step in the workflow without any obvious gain. AS IS form works fine with both types of NemID fields - personal/company. After logging in, the irrelevant ones will be hidden. |
jekuaitk
added a commit
that referenced
this pull request
Mar 27, 2026
…-post Feature/sender address in digital post
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-population of webform fields should only happen when webform type, i.e. “personal” or “company”, is actually set on the form.