OS2FORMS-380

[andriyun]

Part of https://os2web.atlassian.net/browse/OS2FORMS-380

• Oprette changelog i de 3 repoer (os2forms, os2forms_forloeb, os2formsforloeb_profile)
• Oprette github actions til codestandarder (fx https://github.com/itk-dev/os2forms_selvbetjening/blob/develop/.github/workflows/pr.yaml#L77-L105) og tjek om changelog er opdateret.

[rimi-itk]

Looks good. Some comments on coding standards tools added.

[rimi-itk]

I think we should add these to require-dev in composer.json to make it easy to run the checks locally before committing code.

We could also borrow from https://github.com/itk-dev/os2forms_selvbetjening/blob/develop/composer.json#L92-L95 (to also include static code analysis if we dare) and add some helper scripts to make it even easier to run the checks: https://github.com/itk-dev/os2forms_selvbetjening/blob/develop/composer.json#L197-L224

[andriyun]

@rimi-itk thank you for feedback :)

I've added dealerdirect/phpcodesniffer-composer-installer and drupal/coder to as dev dependencies.

Including static code, analysis requires establishing Drupal project structure and injecting the subject repository into it.
IMO it makes more sense to have it on installation like https://github.com/itk-dev/os2forms_selvbetjening

[rimi-itk]

Yes, running code analysis on a Drupal module in a repository is tricky, @andriyun, but it can be done.

We have done it in https://github.com/itk-dev/azure_ad_delta_sync/blob/develop/.github/workflows/pr.yaml#L95-L113, but let's get back to that later.

[andriyun]

I've tried to go with the approach you proposed. It looks like it's not so easy for this case.
This kind of check was not part of this task in the beginning. So I'd rather move it out of scope.

[rimi-itk]

I agree. We should just stick with coding standards for now.

[rimi-itk]

Please apply coding standards.

[andriyun]

@rimi-itk

Please apply coding standards.

Do you mean fix warnings and errors in PHP code sniffer report?

[rimi-itk]

Yes, @andriyun, all checks should succeed in this merge request. Otherwise the checks don't add any value.

[andriyun]

@rimi-itk I've fixed coding standards issues

[rimi-itk]

Excellent work, @andriyun!