OS2FORMS-380

.github/workflows/push.yaml

@@ -0,0 +1,26 @@
+name: Check Code standards
+on: [push]
+jobs:
+  coding-standards:
+    name: PHP - Check Coding Standards
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      # https://github.com/shivammathur/setup-php#cache-composer-dependencies
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+      - name: Cache dependencies
+        uses: actions/cache@v2
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
+
+      - name: Install dependencies
+        run: composer install --no-interaction
+
+      - name: Check coding standards
+        run: composer run coding-standards-check --no-interaction

CHANGELOG.md

@@ -0,0 +1,38 @@
+# OS2Forms Forløb Change Log
+All notable changes to this project should be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/)
+and this project adheres to [Semantic Versioning](http://semver.org/).
+
+See ["how do I make a good changelog record?"](https://keepachangelog.com/en/1.0.0/#how) 
+before starting to add changes.
+
+## [Unreleased]
+
+### Added
+- Github CI action for checking Drupal Coding standards with PHP Code Sniffer
+- Fixed coding standards issues
+
+
+## Example of change log record
+```
+## [x.x.x] Release name
+### Added
+- Description on added functionality.
+
+### Changed/Updated
+- Description on changed/updated functionality.
+
+### Deprecated
+- Description of soon-to-be removed features.
+
+### Removed
+- Description of removed features.
+
+### Fixed
+- Decription of bug fixes.
+
+### Security
+- Security in case of vulnerabilities.
+
+```

composer.json

@@ -54,6 +54,10 @@
     "webmozart/path-util": "^2.3",
     "zaporylie/composer-drupal-optimizations": "^1.2"
   },
+  "require-dev": {
+    "drupal/coder": "^8.3",
+    "dealerdirect/phpcodesniffer-composer-installer": "^0.7.1"
+  },
   "extra": {
     "composer-exit-on-patch-failure": true,
     "patchLevel": {
@@ -80,5 +84,22 @@
         "Duplicated attachments in emails generated by Webform: (https://www.drupal.org/project/smtp/issues/2995290)": "https://www.drupal.org/files/issues/2021-11-02/smtp-2995290-23.patch"
       }
     }
+  },
+  "scripts": {
+    "coding-standards-check/phpcs": [
+      "phpcs --standard=phpcs.xml.dist"
+    ],
+    "coding-standards-check": [
+      "@coding-standards-check/phpcs"
+    ],
+    "coding-standards-apply/phpcs": [
+      "phpcbf --standard=phpcs.xml.dist"
+    ],
+    "coding-standards-apply": [
+      "@coding-standards-apply/phpcs"
+    ]
+  },
+  "config": {
+    "sort-packages": true
   }
 }

css/gin-custom.css

@@ -1,3 +1,3 @@
 .ui-dialog:not(.ui-dialog-off-canvas) {
-    width: 70vw!important;
+  width: 70vw!important;
 }

os2forms_forloeb.info.yml

@@ -6,51 +6,51 @@ core: 8.x
 core_version_requirement: ^8 || ^9
 
 dependencies:
-  - admin_toolbar_tools
-  - coc_forms_auto_export
-  - config_entity_revisions
-  - diff
-  - entity_print
-  - eu_cookie_compliance
-  - events_logging
-  - gin_toolbar
-  - honeypot
-  - libraries
-  - maestro
-  - mailsystem
-  - masquerade
-  - os2forms
-  - os2forms_nemid
-  - os2forms_dawa
-  - os2forms_sbsys
-  - os2web_simplesaml
-  - pathauto
-  - r4032login
-  - redirect
-  - smtp
-  - system
-  - switch_page_theme
-  - token
-  - ultimate_cron
-  - user_default_page
-  - webform
-  - webform_ui
-  - webform_access
-  - webform_attachment
-  - webform_composite
-  - webform_embed
-  - webform_entity_print
-  - webform_entity_print_attachment
-  - webform_migrate
-  - webform_node_element
-  - webform_remote_handlers
-  - webform_rest
-  - webform_revisions
-  - webform_share
-  - webform_scheduled_email
-  - webform_submission_export_import
-  - webform_submission_log
-  - webform_templates
-  - workflow_participants
+  - 'drupal:admin_toolbar_tools'
+  - 'drupal:coc_forms_auto_export'
+  - 'drupal:config_entity_revisions'
+  - 'drupal:diff'
+  - 'drupal:entity_print'
+  - 'drupal:eu_cookie_compliance'
+  - 'drupal:events_logging'
+  - 'drupal:gin_toolbar'
+  - 'drupal:honeypot'
+  - 'drupal:libraries'
+  - 'drupal:maestro'
+  - 'drupal:mailsystem'
+  - 'drupal:masquerade'
+  - 'drupal:os2forms'
+  - 'drupal:os2forms_nemid'
+  - 'drupal:os2forms_dawa'
+  - 'drupal:os2forms_sbsys'
+  - 'drupal:os2web_simplesaml'
+  - 'drupal:pathauto'
+  - 'drupal:r4032login'
+  - 'drupal:redirect'
+  - 'drupal:smtp'
+  - 'drupal:system'
+  - 'drupal:switch_page_theme'
+  - 'drupal:token'
+  - 'drupal:ultimate_cron'
+  - 'drupal:user_default_page'
+  - 'drupal:webform'
+  - 'drupal:webform_ui'
+  - 'drupal:webform_access'
+  - 'drupal:webform_attachment'
+  - 'drupal:webform_composite'
+  - 'drupal:webform_embed'
+  - 'drupal:webform_entity_print'
+  - 'drupal:webform_entity_print_attachment'
+  - 'drupal:webform_migrate'
+  - 'drupal:webform_node_element'
+  - 'drupal:webform_remote_handlers'
+  - 'drupal:webform_rest'
+  - 'drupal:webform_revisions'
+  - 'drupal:webform_share'
+  - 'drupal:webform_scheduled_email'
+  - 'drupal:webform_submission_export_import'
+  - 'drupal:webform_submission_log'
+  - 'drupal:webform_templates'
+  - 'drupal:workflow_participants'
 'interface translation project': os2forms_forloeb
 'interface translation server pattern': modules/contrib/os2forms_forloeb/translations/os2forms_forloeb.da.po