Skip to content

Fix applications sorting #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AramAlsabti merged 1 commit into from
May 25, 2022
Merged

Fix applications sorting #176

AramAlsabti merged 1 commit into from
May 25, 2022

Conversation

@AramAlsabti
Copy link
Contributor

@AramAlsabti AramAlsabti commented May 23, 2022

Applications were not sorted by name unless you were a global admin. This was for two reasons:

  • The organization (and permission) id were not converted to a number
  • If the user isn't an admin, sorting is only applied on the application id

@AramAlsabti AramAlsabti requested a review from GufCab May 23, 2022 14:03
@AramAlsabti AramAlsabti self-assigned this May 23, 2022
@AramAlsabti AramAlsabti merged commit 7d89b7f into stage May 25, 2022
@AramAlsabti AramAlsabti deleted the feature/1358_applicatons-sorting branch May 25, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GufCab GufCab GufCab approved these changes

Assignees

@AramAlsabti AramAlsabti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AramAlsabti @GufCab