Skip to content

Simplify revised permission migration #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 25, 2022
Merged

Simplify revised permission migration #177

merged 4 commits into from
May 25, 2022

Conversation

@AramAlsabti
Copy link
Contributor

@AramAlsabti AramAlsabti commented May 25, 2022

Changes:

  • Updated the revised permission migration in the following way
    • When executing up(), existing permissions won't be duplicated. The new permission type table is created first so that permission levels can be migrated immediately
    • When executing down(), OrganizationUserAdmin becomes an OrganizationAdmin instead of Read
  • Revised default permissions when creating an organization
  • Pass application ids to limit application access for application admins
  • Allow user admin to view applications

Related frontend PR

@AramAlsabti AramAlsabti requested a review from GufCab May 25, 2022 13:57
@AramAlsabti AramAlsabti self-assigned this May 25, 2022
@AramAlsabti AramAlsabti merged commit 3cabae3 into stage May 25, 2022
@AramAlsabti AramAlsabti deleted the feature/1280_simplify-permissions branch May 25, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GufCab GufCab GufCab approved these changes

Assignees

@AramAlsabti AramAlsabti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AramAlsabti @GufCab