Feature/IOT-1583: Move application #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcv-iteratorIt
changed the title
fcv-iteratorIt
approved these changes
Sep 12, 2024
Contributor
fcv-iteratorIt
left a comment
fcv-iteratorIt
left a comment
There was a problem hiding this comment.
Bare et lille nitpick, godt lavet
| @Header("Cache-Control", "none") | ||
| @ApiOperation({ summary: "Update application organization" }) | ||
| @ApiBadRequestResponse() | ||
| async updateOrganization( |
Contributor
There was a problem hiding this comment.
Nitpick: Tror changeOrganization eller moveOrganization er mere sigende
| checkIfUserHasAccessToApplication(req, id, ApplicationAccessScope.Write); | ||
| const application = await this.applicationService.updateOrganization(id, updateApplicationDto, req.user.userId); | ||
|
|
||
| AuditLog.success(ActionType.UPDATE, Application.name, req.user.userId, application.id, application.name); |
Contributor
There was a problem hiding this comment.
Det bør også være et fail log hvis den fejler
…e, with default permissions if none specified.
fcv-iteratorIt
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endpoint for updating organization by permissionIds.