Bugfix/iot 1581 gateway deleted mismatch #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ower case in Chirpstack.
…If any exists, throw exception.
Contributor
Author
|
August har forespurgt, om vi også bør gøre dette eller noget lignende med DeviceEUI, og OTAApplicationKey. For at undgå mismatch mellem case i id'er til chirpstactk, |
fcv-iteratorIt
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Der er løst følgende:
Organization med eksisterende gateways forsøges at blive slettet, hvilket sletter gateways i db og ikke chirpstack.
Gateway id er oprettet med uppercase enten i db/gennem api
Ud over dto og db entity transformer decorators, er der også lavet en del gatewayId.tolowerCase - dette er evt redundant ud over ved create. Det skal i hvert fald overvejes om det bliver for rodet, da det ikke er en case der skulle kunne rammes, medmindre der anvendes postman/lignende.