This repository was archived by the owner on Oct 18, 2018. It is now read-only.
Handle spaces in domain groups correctly #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version of this file wouldn't handle spaces in a group - for example if a user had "domain users" as their group, it would fail to start up nginx with an 'incorrect number of arguments' error. Adding the single quotes around this fixes that.
Contributor
|
Excellent. Thanks! |
Contributor
|
@CJCShadowsan what platform are you installing OnDemand on that you had the need to support groups whose name had a space in them? Yours may be a new case we haven't considered. I'm wondering if we are making other assumptions that we should address. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version of this file wouldn't handle spaces in a group - for example if a user had "domain users" as their group, it would fail to start up nginx with an 'incorrect number of arguments' error. Adding the single quotes around this fixes that.