Skip to content

Conversation

@romulojales
Copy link
Contributor

Modify this link to include the branch name, and possibly the page this PR modifies:

https://osc.github.io/ood-documentation-test/latest/authentication/adfs-with-auth-mellon.html

Add your description here

Adding specific paths, commands and quirks when configuring SAML (mellon) in Ubuntu.

@romulojales romulojales marked this pull request as ready for review March 25, 2025 15:26
@johrstrom
Copy link
Contributor

I'd merge this quickly, but I just need a minute to pull it down and verify the formatting is OK - I believe the content is fine, but formatting can be tricky. I'm busy juggling a few other things, but I'll get to this shortly.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@johrstrom
Copy link
Contributor

Went to merge this, and see your commits aren't attributed correctly to your github user. I'm OK to merge as is, but I think it's important you get full credit, so if you want to fix the commits you can do so now.

image

@romulojales romulojales force-pushed the saml-ubuntu branch 2 times, most recently from 7957a0c to 4c13c41 Compare March 26, 2025 22:03
Adding specific paths, commands and quirks when configuring SAML in Ubuntu.
@romulojales
Copy link
Contributor Author

romulojales commented Mar 26, 2025

Went to merge this, and see your commits aren't attributed correctly to your github user. I'm OK to merge as is, but I think it's important you get full credit, so if you want to fix the commits you can do so now.

image

@johrstrom , thank you for noting that. I've amended the commits with my public profile.

@johrstrom johrstrom merged commit 10cb1ef into OSC:latest Mar 27, 2025
1 check failed
@johrstrom
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants